Compare commits

..

No commits in common. "ae59f826e9d292ad04c5f9f03d9e0bb4cc353a67" and "8772331868f6578ae983a6a1bf4ad2405528c498" have entirely different histories.

6 changed files with 32 additions and 16 deletions

View File

@ -4,8 +4,6 @@
use App\Models\User; use App\Models\User;
use Illuminate\Http\Request; use Illuminate\Http\Request;
use Illuminate\Support\Facades\Validator;
use Symfony\Component\HttpFoundation\Exception\BadRequestException;
class UserController extends Controller class UserController extends Controller
{ {
@ -18,15 +16,6 @@ public function index()
// GET /user/{id} // GET /user/{id}
public function show(string $id) public function show(string $id)
{ {
// FIXME: is there more shorter
// validation solution
$v = Validator::make(["id" => $id], [
"id" => 'integer'
]);
if ($v->fails())
throw new BadRequestException();
$user = User::query()->findOrFail($id); $user = User::query()->findOrFail($id);
return response($user); return response($user);

View File

@ -0,0 +1,10 @@
<?php
namespace Tests\Feature;
use Tests\TestCase;
class CommentaryTest extends TestCase
{
//
}

View File

@ -0,0 +1,10 @@
<?php
namespace Tests\Feature;
use Tests\TestCase;
class PostTest extends TestCase
{
//
}

10
tests/Feature/TagTest.php Normal file
View File

@ -0,0 +1,10 @@
<?php
namespace Tests\Feature;
use Tests\TestCase;
class TagTest extends TestCase
{
//
}

View File

@ -3,14 +3,12 @@
namespace Tests\Feature; namespace Tests\Feature;
use App\Models\User; use App\Models\User;
use Illuminate\Foundation\Testing\RefreshDatabase;
use Tests\TestCase; use Tests\TestCase;
class UserTest extends TestCase class UserTest extends TestCase
{ {
// FIXME: tests should be // FIXME: tests should be
// grouped and be separated in several files // grouped and be separated in several files
use RefreshDatabase;
public function test_success_get_users(): void public function test_success_get_users(): void
{ {
@ -36,6 +34,6 @@ public function test_fail_get_user_not_exists(): void
// but in future updates id // but in future updates id
// will be uuid, it is safer // will be uuid, it is safer
$this->get('/user/sehtrgher') $this->get('/user/sehtrgher')
->assertBadRequest(); ->assertNotFound();
} }
} }

View File

@ -2,10 +2,9 @@
namespace Tests; namespace Tests;
use Illuminate\Foundation\Testing\RefreshDatabase;
use Illuminate\Foundation\Testing\TestCase as BaseTestCase; use Illuminate\Foundation\Testing\TestCase as BaseTestCase;
abstract class TestCase extends BaseTestCase abstract class TestCase extends BaseTestCase
{ {
protected $seed = true; //
} }